Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use quotas in default performance tests" #60989

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Revert "Use quotas in default performance tests" #60989

merged 1 commit into from
Mar 9, 2018

Conversation

shyamjvs
Copy link
Member

@shyamjvs shyamjvs commented Mar 9, 2018

This reverts commit c3c1020.

Ref #60988

/cc @gmarek
/kind bug
/sig scalability
/priority critical-urgent

NONE

@k8s-ci-robot k8s-ci-robot requested a review from gmarek March 9, 2018 17:23
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 9, 2018
@shyamjvs shyamjvs added this to the v1.10 milestone Mar 9, 2018
@gmarek
Copy link
Contributor

gmarek commented Mar 9, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@gmarek @shyamjvs

Pull Request Labels
  • sig/scalability: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmarek, shyamjvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shyamjvs
Copy link
Member Author

shyamjvs commented Mar 9, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 40143fd into kubernetes:master Mar 9, 2018
@shyamjvs shyamjvs deleted the disable-quotas-in-scalability-e2es branch March 9, 2018 19:41
@shyamjvs
Copy link
Member Author

@jdumars Quick question - when can we expect this PR to land into 10.0-beta? This is currently causing failures in the scalability job running against beta - #60988 (comment) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@gmarek gmarek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shyamjvs @gmarek @k8s-github-robot @k8s-ci-robot